Conversation
julianajlk
force-pushed
the
julianajlk/REV-1632/price-discrepancy-coursemode-newcol
branch
2 times, most recently
from
ffe9517 to
9550dcc
Compare
julianajlk
force-pushed
the
julianajlk/REV-1632/price-discrepancy-coursemode-newcol
branch
from
9550dcc to
dc4a20c
Compare
julianajlk
force-pushed
the
julianajlk/REV-1632/price-discrepancy-coursemode-newcol
branch
from
dc4a20c to
0fd03ef
Compare
|
Your PR has finished running tests. The following contexts failed:
|
|
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build. We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master. This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself: If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal). |
|
Closing as this work was reprioritized. |
nedbat
deleted the
julianajlk/REV-1632/price-discrepancy-coursemode-newcol
branch
3 participants
REV-1632.
The
min_pricecolumn inCourseModetable takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).This ticket:
Add new price column with type Decimal, populate the column with the same data
min_pricecolumn has, which is now sent as a float fromLMSPublisherrequest.In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce.
min_pricecan receive non-int.LMSPublisherto stop converting min_price to int.min_price.min_pricecolumn.